Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D94D919F3E for ; Wed, 20 Apr 2016 01:48:34 +0000 (UTC) Received: (qmail 91024 invoked by uid 500); 20 Apr 2016 01:48:34 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 90975 invoked by uid 500); 20 Apr 2016 01:48:34 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 90966 invoked by uid 99); 20 Apr 2016 01:48:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Apr 2016 01:48:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 45757C0BC3 for ; Wed, 20 Apr 2016 01:48:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ToY65fbHzkme for ; Wed, 20 Apr 2016 01:48:33 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 109005FAF2 for ; Wed, 20 Apr 2016 01:48:31 +0000 (UTC) Received: (qmail 90617 invoked by uid 99); 20 Apr 2016 01:48:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Apr 2016 01:48:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C92B42C1F6E for ; Wed, 20 Apr 2016 01:48:25 +0000 (UTC) Date: Wed, 20 Apr 2016 01:48:25 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-215) Create should be implemented as a BoundedSource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249110#comment-15249110 ] ASF GitHub Bot commented on BEAM-215: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/214 [BEAM-215] Override Create in the SparkPipelineRunner Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This allows existing pipelines to continue to function by keeping the graph structure identical while replacing Create with a Read. After [BEAM-17](https://issues.apache.org/jira/browse/BEAM-17?jql=project%20%3D%20BEAM%20AND%20resolution%20%3D%20Unresolved%20AND%20text%20~%20%22create%22%20ORDER%20BY%20priority%20DESC) this override can be removed. See #183 for more information. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam spark_override_create Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 ---- commit 78afdb39bbe75099e74678535268360f77d5fa96 Author: Thomas Groh Date: 2016-04-19T23:12:32Z Override Create in the SparkPipelineRunner This allows existing pipelines to continue to function by keeping the graph structure identical while replacing Create with a Read. ---- > Create should be implemented as a BoundedSource > ----------------------------------------------- > > Key: BEAM-215 > URL: https://issues.apache.org/jira/browse/BEAM-215 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Davor Bonaci > > Read.Bounded is the primitive to create a Bounded PCollection, and Create can be implemented as a BoundedSource. The primitive implementation of Create can be replaced with a source, which allows it to also automatically get any benefits provided by the Runner's exercising of the Source API > See also BEAM-115 -- This message was sent by Atlassian JIRA (v6.3.4#6332)