Return-Path: 
 <commits-return-2103-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org>
X-Original-To: apmail-beam-commits-archive@minotaur.apache.org
Delivered-To: apmail-beam-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3C39119D54
	for <apmail-beam-commits-archive@minotaur.apache.org>;
 Wed, 13 Apr 2016 18:04:51 +0000 (UTC)
Received: (qmail 29864 invoked by uid 500); 13 Apr 2016 18:04:47 -0000
Delivered-To: apmail-beam-commits-archive@beam.apache.org
Received: (qmail 29744 invoked by uid 500); 13 Apr 2016 18:04:47 -0000
Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@beam.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@beam.incubator.apache.org>
List-Post: <mailto:commits@beam.incubator.apache.org>
List-Id: <commits.beam.incubator.apache.org>
Reply-To: dev@beam.incubator.apache.org
Delivered-To: mailing list commits@beam.incubator.apache.org
Received: (qmail 29690 invoked by uid 99); 13 Apr 2016 18:04:47 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
 spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 18:04:47 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id 2EF2DC2555
	for <commits@beam.apache.org>; Wed, 13 Apr 2016 17:56:29 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -1.73
X-Spam-Level: 
X-Spam-Status: No, score=-1.73 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001, TVD_SUBJ_WIPE_DEBT=2.291] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id 0LkiDNaoNxQo for <commits@beam.apache.org>;
	Wed, 13 Apr 2016 17:56:27 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP
 id 5AF645FB7D
	for <commits@beam.incubator.apache.org>;
 Wed, 13 Apr 2016 17:56:26 +0000 (UTC)
Received: (qmail 99107 invoked by uid 99); 13 Apr 2016 17:56:25 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 17:56:25 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 78ADB2C14E1
	for <commits@beam.incubator.apache.org>;
 Wed, 13 Apr 2016 17:56:25 +0000 (UTC)
Date: Wed, 13 Apr 2016 17:56:25 +0000 (UTC)
From: "Kenneth Knowles (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12958539.1460570126000.221399.1460570185489@Atlassian.JIRA>
In-Reply-To: <JIRA.12958539.1460570126000@Atlassian.JIRA>
References: <JIRA.12958539.1460570126000@Atlassian.JIRA>
 <JIRA.12958539.1460570126162@arcas>
Subject: [jira] [Created] (BEAM-191) Remove
 WindowedValue.valueInEmptyWindows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Kenneth Knowles created BEAM-191:
------------------------------------

             Summary: Remove WindowedValue.valueInEmptyWindows
                 Key: BEAM-191
                 URL: https://issues.apache.org/jira/browse/BEAM-191
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Kenneth Knowles
            Priority: Minor


Even though it is acceptable to create a WindowedValue carrying no windows when it is a fully reified WindowedValue<T>, it doesn't really make sense: When it becomes an element in a PCollection that a value must exist within some window.

This has led to some confusion so we should remove the API. It seems there are just 11 files that reference WindowedValue.valueInEmptyWindows [1] that mostly look like they'd be fine with the global window.

[1] https://github.com/apache/incubator-beam/search?p=1&q=valueInEmptyWindows&utf8=%E2%9C%93



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)