Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07B0E1963F for ; Fri, 8 Apr 2016 18:57:30 +0000 (UTC) Received: (qmail 13592 invoked by uid 500); 8 Apr 2016 18:57:30 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 13554 invoked by uid 500); 8 Apr 2016 18:57:29 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 13544 invoked by uid 99); 8 Apr 2016 18:57:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 18:57:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 62DA6C023C for ; Fri, 8 Apr 2016 18:57:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id y_oNM9KY1C10 for ; Fri, 8 Apr 2016 18:57:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 6A7755F23A for ; Fri, 8 Apr 2016 18:57:26 +0000 (UTC) Received: (qmail 12414 invoked by uid 99); 8 Apr 2016 18:57:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 18:57:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8D3892C1F4E for ; Fri, 8 Apr 2016 18:57:25 +0000 (UTC) Date: Fri, 8 Apr 2016 18:57:25 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-155) Support asserting the contents of windows and panes in PAssert MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232713#comment-15232713 ] ASF GitHub Bot commented on BEAM-155: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/150 [BEAM-155] Make PassThroughWindowFn and NeverTrigger available Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace "" in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This will be used as part of the new PAssert PassThroughWindowFn remains package-private to restrict usage. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam pass_through_window_fn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 ---- commit 2d8189ff2948e8b294e253f087d741e4d122658b Author: Thomas Groh Date: 2016-03-31T21:34:06Z Make PassThroughWindowFn and NeverTrigger available This will be used as part of the new PAssert PassThroughWindowFn remains package-private to restrict usage. ---- > Support asserting the contents of windows and panes in PAssert > -------------------------------------------------------------- > > Key: BEAM-155 > URL: https://issues.apache.org/jira/browse/BEAM-155 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Thomas Groh > > This consists of reifying the output windows and panes, and running asserts per-window about the contents of panes. > This includes aggregated matching and final pane matching, e.g. > PAssert.that(output).byOnTimePane().hasOutputElements(foo, bar); > // For discarding mode - could have emitted (say) [spam, eggs], [spam], [], [sausage], [] > PAssert.that(output).byFinalPane().hasOutputElements(spam, eggs, sausage, spam); > // For accumulating mode without late data > PAssert.that(output).finalPane().containsInAnyOrder(spam, eggs, sausage, spam); > // For accumulating mode with late data > PAssert.that(output).finalPane().containsInAnyOrder(foo, bar).mayAlsoContain(baz, rab); > See also: https://docs.google.com/document/d/1fZUUbG2LxBtqCVabQshldXIhkMcXepsbv2vuuny8Ix4/edit# -- This message was sent by Atlassian JIRA (v6.3.4#6332)