Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2A1EA19BB1 for ; Tue, 26 Apr 2016 16:00:20 +0000 (UTC) Received: (qmail 82935 invoked by uid 500); 26 Apr 2016 16:00:20 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 82884 invoked by uid 500); 26 Apr 2016 16:00:20 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 82870 invoked by uid 99); 26 Apr 2016 16:00:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 16:00:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AA92BC0715 for ; Tue, 26 Apr 2016 16:00:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0A8k_-B6suae for ; Tue, 26 Apr 2016 16:00:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id E5B215FAC9 for ; Tue, 26 Apr 2016 16:00:14 +0000 (UTC) Received: (qmail 81783 invoked by uid 99); 26 Apr 2016 16:00:14 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 16:00:14 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E446A2C14F4 for ; Tue, 26 Apr 2016 16:00:13 +0000 (UTC) Date: Tue, 26 Apr 2016 16:00:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-117) Implement the API for Static Display Metadata MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258326#comment-15258326 ] ASF GitHub Bot commented on BEAM-117: ------------------------------------- GitHub user swegner opened a pull request: https://github.com/apache/incubator-beam/pull/241 [BEAM-117] Minor updates for DisplayData usage Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This PR addresses the following JIRA issues: * [[BEAM-195] Rename DisplayDataMatchers#includes](https://issues.apache.org/jira/browse/BEAM-195) * [[BEAM-200] Standardize terminology to "display data" in documentation](https://issues.apache.org/jira/browse/BEAM-200) * [[BEAM-219] Use super.populateDisplayData consistently](https://issues.apache.org/jira/browse/BEAM-219) [[BEAM-199] Improve fluent interface for manipulating DisplayData.Items](https://issues.apache.org/jira/browse/BEAM-199) will be in the next PR as to not bloat this one too much. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swegner/incubator-beam displaydata-tweaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #241 ---- commit 08b475f1971b3f74c9b321941cdbe2818c25c939 Author: Scott Wegner Date: 2016-04-25T16:31:13Z Rename DisplayDataMatchers.includes to includesDisplayData to clarify usage commit 5a1d93ce01000df8577acd66d6e9c6ebf5d6948f Author: Scott Wegner Date: 2016-04-25T16:34:58Z Normalize comments to refer to 'display data' rather than 'display metadata' commit 954e734fbde4a055ee97d84b9f1c91d598fc5de9 Author: Scott Wegner Date: 2016-04-25T16:41:07Z Add super.populateDisplayData() to standard implementations. The current super implementation is a no-op, but this is the recommended way to implement the pattern ---- > Implement the API for Static Display Metadata > --------------------------------------------- > > Key: BEAM-117 > URL: https://issues.apache.org/jira/browse/BEAM-117 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core > Reporter: Ben Chambers > Assignee: Scott Wegner > > As described in the following doc, we would like the SDK to allow associating display metadata with PTransforms. > https://docs.google.com/document/d/11enEB9JwVp6vO0uOYYTMYTGkr3TdNfELwWqoiUg5ZxM/edit?usp=sharing -- This message was sent by Atlassian JIRA (v6.3.4#6332)