Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F614190B7 for ; Wed, 6 Apr 2016 17:38:28 +0000 (UTC) Received: (qmail 3448 invoked by uid 500); 6 Apr 2016 17:38:28 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 3400 invoked by uid 500); 6 Apr 2016 17:38:28 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 3391 invoked by uid 99); 6 Apr 2016 17:38:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 17:38:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1C4E61A0083 for ; Wed, 6 Apr 2016 17:38:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id J-38GZQyXDwe for ; Wed, 6 Apr 2016 17:38:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 752375F202 for ; Wed, 6 Apr 2016 17:38:26 +0000 (UTC) Received: (qmail 2968 invoked by uid 99); 6 Apr 2016 17:38:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 17:38:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 90A232C1F5C for ; Wed, 6 Apr 2016 17:38:25 +0000 (UTC) Date: Wed, 6 Apr 2016 17:38:25 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-44) Return the input coder in NullableCoder.of() if it is a NullableCoder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228711#comment-15228711 ] ASF GitHub Bot commented on BEAM-44: ------------------------------------ Github user asfgit closed the pull request at: https://github.com/apache/incubator-beam/pull/136 > Return the input coder in NullableCoder.of() if it is a NullableCoder > --------------------------------------------------------------------- > > Key: BEAM-44 > URL: https://issues.apache.org/jira/browse/BEAM-44 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Thomas Groh > Priority: Trivial > > {{NullableCoder.of(NullableCoder.of(foo))}} returns a nested {{NullableCoder}}, which appends two "present" bytes before null values. The second coder is unnecessary, and does not need to be provided. Instead, in the factory method, return the input coder if it is already a {{NullableCoder}}. > {code} > NullableCoder of(Coder coder) { > if (coder instanceof NullableCoder) return coder; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)