beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request: [BEAM-115] Make in-process GroupByKey...
Date Fri, 29 Apr 2016 17:41:38 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-115] Make in-process GroupByKey consistent with Beam model

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This is rebased onto #256.

You can merge this pull request into a Git repository by running:

    $ git pull InProcessGroupByKey

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #268
commit 310f8c4477fbcc16815af69592158ea5df1a8d6d
Author: Kenneth Knowles <>
Date:   2016-04-27T22:01:48Z

    Move InProcessRunner to its own module

commit 89cfe6bf22dd5849d52237f0a9b3cd9d55e6ec11
Author: Kenneth Knowles <>
Date:   2016-04-28T22:51:40Z

    Add accessors for sub-coders of KeyedWorkItemCoder

commit 41568a8c3318ea4e15c68e2cf4d61e18c94867ce
Author: Kenneth Knowles <>
Date:   2016-04-28T23:12:21Z

    Make in-process GroupByKey respect future Beam model
    This introduces or clarifies the following transforms:
     - InProcessGroupByKey, which expands like GroupByKeyViaGroupByKeyOnly
       but with different intermediate PCollection types.
     - InProcessGroupByKeyOnly, which outputs KeyedWorkItem<K, V>. This existed
       already under a different name.
     - InProcessGroupAlsoByWindow, which is evaluated directly and
       accepts input elements of type KeyedWorkItem<K, V>.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message