beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-22] Remove redundant close in B...
Date Thu, 28 Apr 2016 00:10:46 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/257

    [BEAM-22] Remove redundant close in BoundedReadEvaluatorFactory

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The reader is already closed by virtue of being the target of the
    try-with-resources block that encompasses all of #finishBundle().
    
    Calling close on the reader twice causes KafkaIO to throw an exception.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam remove_redundant_bounded_reader_close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #257
    
----
commit 08c05e01b6248de853e8bc3d8446ed98d3408a6e
Author: Thomas Groh <tgroh@google.com>
Date:   2016-04-28T00:03:44Z

    Remove redundant close in BoundedReadEvaluatorFactory
    
    The reader is already closed by virtue of being the target of the
    try-with-resources block that encompasses all of #finishBundle().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message