beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Create build-tools module with consol...
Date Tue, 26 Apr 2016 23:24:04 GMT
GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/246

    Create build-tools module with consolidated checkstyle config

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This creates a new top-level `build-tools` maven module which holds our checkstyle config
and can be references from other modules. 
    
    This follows the recommended project structure laid out in [Checkstyle Example: Multimodule
Configuration](https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html),
which will also be useful for incorporating FindBugs in the build.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam buildtools

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit 737e34c782df34a8ab9ec4b50e8e9b1b2e83d13b
Author: Scott Wegner <swegner@google.com>
Date:   2016-04-26T17:49:26Z

    Consolidate checkstyle configuration in new 'build-tools' module

commit eb7db3a81766708a24d3c6cb0d1ce38868281892
Author: Scott Wegner <swegner@google.com>
Date:   2016-04-26T18:01:16Z

    Remove unused imort in Kafka test file

commit ec1296680e009653ede0a341341e0087631d4bc1
Author: Scott Wegner <swegner@google.com>
Date:   2016-04-26T18:04:04Z

    Improve checkstyle header check

commit 1da2055484012523bbcd12536d4f6f7db391caca
Author: Scott Wegner <swegner@google.com>
Date:   2016-04-26T18:21:51Z

    Improve comment validation checks

commit eb52d5835a1f4ad2787e07ee3b91b6f34114a131
Author: Scott Wegner <swegner@google.com>
Date:   2016-04-26T21:27:45Z

    Upgrade checkstyle to latest version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message