beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-151] Move over some more Datafl...
Date Tue, 26 Apr 2016 18:48:26 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/243

    [BEAM-151] Move over some more Dataflow specific classes.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Note that users should use proto ByteString instead of RandomAccessData
    since it provides a safer version of the same functionality.
    
    I hoped that I would be able to move over more of the *Cloud* classes
    and their helpers but they are embedded part of coders. Nothing more
    can be done here until there is an official Beam representation of a coder
    decoupled from Dataflow CloudKnownTypes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam beam151

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #243
    
----
commit 305c002ecbbe031458dcc2da66b4a2a0b5f41174
Author: Luke Cwik <lcwik@google.com>
Date:   2016-04-26T18:43:26Z

    [BEAM-151] Move over some more Dataflow specific classes.
    
    Note that users should use proto ByteString instead of RandomAccessData
    since it provides a safer version of the same functionality.
    
    I hoped that I would be able to move over more of the *Cloud* classes
    and their helpers but they are embedded part of coders. Nothing more
    can be done here until there is an official Beam representation of a coder
    decoupled from Dataflow CloudKnownTypes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message