beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request: [BEAM-115] Remove extraneous type par...
Date Mon, 11 Apr 2016 22:16:07 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-115] Remove extraneous type parameter from Trigger, etc

    This has no user-visible effect unless they have to declare a variable of type `Trigger`,
etc, since we use factory methods where extra type parameters are just a warning. For this
PR, I have deliberately _not_ cleared out such parameters from examples or integration tests,
to be sure that nothing is broken. I will follow up with that.
    This is in service of the runner API in that triggers move towards a cross-language cross-runner
syntax and clearing out this type parameter makes it easier to proceed with further refactors.

You can merge this pull request into a Git repository by running:

    $ git pull Trigger-window

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
commit de9f10c4b23912b590dd66e42a4fc4e0513fe6fd
Author: Kenneth Knowles <>
Date:   2016-04-11T21:49:21Z

    Remove extraneous type parameter from Trigger, etc


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message