beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-151] Move Dataflow runner to ne...
Date Mon, 11 Apr 2016 19:58:56 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/165

    [BEAM-151] Move Dataflow runner to new Dataflow runner maven module

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Note that Flink runner and Java examples both depend on the Dataflow runner still. So
I needed to make the Dataflow runner a top level component to satisfy these dependencies.
    
    Also, we are currently shading within the Dataflow runner and using the same namespace
to reduce the jar size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam dataflow-runner-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #165
    
----
commit 0c45173b206b97825b6a9c24d095efba110eb405
Author: Luke Cwik <lcwik@google.com>
Date:   2016-04-11T19:49:07Z

    [BEAM-151] Move a large portion of the Dataflow runner to separate maven module
    
    Note that Flink runner and Java examples both depend on the Dataflow runner
    still. So I needed to make the Dataflow runner a top level component to
    satisfy these dependencies.

commit 31ca6c214e0e90a5acd0cfc895b01a97b20a165c
Author: Luke Cwik <lcwik@google.com>
Date:   2016-04-11T19:55:53Z

    [BEAM-151] !fixup Add comment explaining build order change

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message