beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-22] Fix multithreaded visibilit...
Date Mon, 11 Apr 2016 16:12:12 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/161

    [BEAM-22] Fix multithreaded visibility issue with TransformExecutor

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Use an AtomicReference to ensure the thread the Executor is being run on
    will be visible to other threads.
    
    Add a checkState to ensure that the executor will not run more than
    once.
    
    Stop setting the active thread to null, as the Transform Executor should
    be discarded from any refernces and not hold the overall execution.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam data_race_ippr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 33556f2a94924effae56de119444e29eeaf8e498
Author: Thomas Groh <tgroh@google.com>
Date:   2016-04-11T15:54:58Z

    Fix multithreaded visibility issue with TransformExecutor
    
    Use an AtomicReference to ensure the thread the Executor is being run on
    will be visible to other threads.
    
    Add a checkState to ensure that the executor will not run more than
    once.
    
    Stop setting the active thread to null, as the Transform Executor should
    be discarded from any refernces and not hold the overall execution.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message