beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-151] Move maven archetypes buil...
Date Sat, 09 Apr 2016 01:49:36 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/158

    [BEAM-151] Move maven archetypes build order to be after runners

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    sdks/java/maven-archtypes has several dependencies on the DataflowPipelineRunner. Until
these are refactored out or a released artifact exists, we need to modify the build order.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam dataflow-runner-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #158
    
----
commit ba4cdc5f3f753d6a3fd26f6b6d4e2f9c3d8f7e70
Author: Luke Cwik <lcwik@google.com>
Date:   2016-04-09T01:37:46Z

    [BEAM-151] Move maven archetypes build order to be after runners
    
    Currently sdks/java/maven-archetypes has several dependencies
    on the DataflowPipelineRunner. This is mainly throw the utility
    class called DataflowExampleUtils.
    
    This is a temporary workaround till examples get updated
    to use only beam SDK.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message