beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: FileBasedSource: throw IOException in...
Date Fri, 08 Apr 2016 23:12:34 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/155

    FileBasedSource: throw IOException instead of Exception where possible

    - Replace "throws Exception" with "throws IOException" from APIs
      that already only throw IOException.
    - Refactor one function to catch, handle, and rethrow
      (Interrupted|Execution)Exception.
    
    This makes it easier to write a new FileBasedSource, because the
    FilebasedReader functions are only registered to throw IOException.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam filebasedsource

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 8c3c94b6e8809d0ea7e276e9a0e29799182817df
Author: Dan Halperin <dhalperi@google.com>
Date:   2016-04-08T23:09:21Z

    FileBasedSource: throw IOException instead of Exception where possible
    
    - Replace "throws Exception" with "throws IOException" from APIs
      that already only throw IOException.
    - Refactor one function to catch, handle, and rethrow
      (Interrupted|Execution)Exception.
    
    This makes it easier to write a new FileBasedSource, because the
    FilebasedReader functions are only registered to throw IOException.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message