beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-22] Clear Empty TransformExecut...
Date Thu, 07 Apr 2016 18:49:35 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/143

    [BEAM-22] Clear Empty TransformExecutorServices

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This reduces the amount of objects tracked by the ExecutorServiceParallelExecutor
    when keys stop appearing. If this is not done, as new keys show up and no more
    work appears for old keys, the number of TransformExecutorServices grows, and
    we maintain a reference for all of them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam ippr_empty_evaluation_state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 066ae4526c229f1e9c11172aae82aaccbde09c42
Author: Thomas Groh <tgroh@google.com>
Date:   2016-03-29T17:27:37Z

    Schedule all pending work before firing timers
    
    Pull all available work off of the ExecutorUpdate queue during each
    execution of the MonitorRunnable.

commit c3ae8460b0f49bcb5d6d5e47d29152ccc411bf99
Author: Thomas Groh <tgroh@google.com>
Date:   2016-03-29T17:56:10Z

    Clean up empty TransformExecutorServices
    
    This allows the size of the currentEvaluations map in
    ExecutorServiceParallelExecutor to be based on the number of keys for
    serial computations that are currently in-progress, rather than
    the number of keys for serializable computations for the entire life of
    the pipeline.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message