beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Improve TestPipeline AppName detectio...
Date Wed, 06 Apr 2016 16:23:06 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/134

    Improve TestPipeline AppName detection

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    After encountering the TestPipeline portion of the stack, try to find
    a method annotated with the org.junit.Test annotation. If such a method
    is found, return it as the StackTraceElement of the calling class.
    
    This improves TestPipeline name detection for RunnableOnService tests to
    avoid duplication

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam test_pipeline_name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit db66b64882465a3e7f77335b8fcc1b08d4aba72a
Author: Thomas Groh <tgroh@google.com>
Date:   2016-04-06T01:09:29Z

    Improve TestPipeline AppName detection
    
    After encountering the TestPipeline portion of the stack, try to find
    a method annotated with the org.junit.Test annotation. If such a method
    is found, return it as the StackTraceElement of the calling class.
    
    This improves TestPipeline name detection for RunnableOnService tests to
    avoid duplication

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message