beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-22] Add PTransformOverride clas...
Date Tue, 05 Apr 2016 22:14:17 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/131

    [BEAM-22] Add PTransformOverride class

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This provides the #shouldOverride method to determine if a PTransform
    override should be applied, based on the original PTransform.
    
    This permits overrides that are applied conditionally (such as
    shard-controlled writes).
    
    For all existing overrides, this value is equal to true.
    
    This is used in (written, but unpublished) overrides for TextIO.Write and
    AvroIO.Write, so the write can be overridden in terms of sharded writes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam ippr_ptransform_override_class

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit 624ccb9359779161c2e5d6a79dc9b865aa22efb3
Author: Thomas Groh <tgroh@google.com>
Date:   2016-03-29T17:03:25Z

    Add PTransformOverride class
    
    This provides the #shouldOverride method to determine if a PTransform
    override should be applied, based on the original PTransform.
    
    This permits overrides that are applied conditionally (such as
    shard-controlled writes).
    
    For all existing overrides, this value is equal to true.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message