beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-222) TestCounterSource does not implement checkpointing contract
Date Tue, 26 Apr 2016 23:37:12 GMT

    [ https://issues.apache.org/jira/browse/BEAM-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259187#comment-15259187
] 

ASF GitHub Bot commented on BEAM-222:
-------------------------------------

GitHub user mshields822 opened a pull request:

    https://github.com/apache/incubator-beam/pull/248

    [BEAM-222] Don't advance beyond last valid value

    Turns out there was a bug with allowing 'advanced beyond last element' to be a valid counter
state.
    Only an internal reload test caught it.
    Included unit test for that case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mshields822/incubator-beam beam-222

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #248
    
----
commit 2631624ae820df66206d8bdcc2e1d84bedbc696a
Author: Mark Shields <markshields@google.com>
Date:   2016-04-26T23:34:32Z

    Don't advance beyond last valid value

----


> TestCounterSource does not implement checkpointing contract
> -----------------------------------------------------------
>
>                 Key: BEAM-222
>                 URL: https://issues.apache.org/jira/browse/BEAM-222
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
>
> It will yield repeated values when restored from a checkpoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message