beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-215) Create should be implemented as a BoundedSource
Date Fri, 22 Apr 2016 17:49:12 GMT

    [ https://issues.apache.org/jira/browse/BEAM-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254306#comment-15254306
] 

ASF GitHub Bot commented on BEAM-215:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/232

    [BEAM-215] Fix CreateSource#getBytesPerOffset

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Return 1L when there are no elements, as the default value.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam fix_bytes_per_offset_create

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #232
    
----
commit c98b5d6bcf20e7a232730ec1aae05a5f91e1bcf4
Author: Thomas Groh <tgroh@google.com>
Date:   2016-04-22T17:46:50Z

    Fix CreateSource#getBytesPerOffset
    
    Return 1L when there are no elements, as the default value.

----


> Create should be implemented as a BoundedSource
> -----------------------------------------------
>
>                 Key: BEAM-215
>                 URL: https://issues.apache.org/jira/browse/BEAM-215
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> Read.Bounded is the primitive to create a Bounded PCollection, and Create can be implemented
as a BoundedSource. The primitive implementation of Create can be replaced with a source,
which allows it to also automatically get any benefits provided by the Runner's exercising
of the Source API
> See also BEAM-115



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message