beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-202) Remove YYYCoderBase
Date Fri, 15 Apr 2016 23:59:25 GMT

    [ https://issues.apache.org/jira/browse/BEAM-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243875#comment-15243875
] 

ASF GitHub Bot commented on BEAM-202:
-------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/194

    [BEAM-202] Clean-up *CoderBase classes

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    We are on Jackson 2.7.0 now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam remove_coder_base

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #194
    
----
commit 11e8bfed4c73ec21dcf5a671ff0381ec1f39d8d4
Author: Luke Cwik <lcwik@google.com>
Date:   2016-04-15T23:53:23Z

    [BEAM-202] Clean-up *CoderBase classes since we are on a newer version of Jackson

----


> Remove YYYCoderBase
> -------------------
>
>                 Key: BEAM-202
>                 URL: https://issues.apache.org/jira/browse/BEAM-202
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>
> Jackson 2.4.5 had a bug where it couldn't deserialize types with multiple generic parameters.
Since we are on Jackson 2.7.0, we can remove KvCoderBase and MapCoderBase



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message