beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Created] (BEAM-191) Remove WindowedValue.valueInEmptyWindows
Date Wed, 13 Apr 2016 17:56:25 GMT
Kenneth Knowles created BEAM-191:
------------------------------------

             Summary: Remove WindowedValue.valueInEmptyWindows
                 Key: BEAM-191
                 URL: https://issues.apache.org/jira/browse/BEAM-191
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Kenneth Knowles
            Priority: Minor


Even though it is acceptable to create a WindowedValue carrying no windows when it is a fully
reified WindowedValue<T>, it doesn't really make sense: When it becomes an element in
a PCollection that a value must exist within some window.

This has led to some confusion so we should remove the API. It seems there are just 11 files
that reference WindowedValue.valueInEmptyWindows [1] that mostly look like they'd be fine
with the global window.

[1] https://github.com/apache/incubator-beam/search?p=1&q=valueInEmptyWindows&utf8=%E2%9C%93



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message