beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-117) Implement the API for Static Display Metadata
Date Tue, 26 Apr 2016 16:00:13 GMT


ASF GitHub Bot commented on BEAM-117:

GitHub user swegner opened a pull request:

    [BEAM-117] Minor updates for DisplayData usage

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This PR addresses the following JIRA issues:
    * [[BEAM-195] Rename DisplayDataMatchers#includes](
    * [[BEAM-200] Standardize terminology to "display data" in documentation](
    * [[BEAM-219] Use super.populateDisplayData consistently](
    [[BEAM-199] Improve fluent interface for manipulating DisplayData.Items](
will be in the next PR as to not bloat this one too much.

You can merge this pull request into a Git repository by running:

    $ git pull displaydata-tweaks

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #241
commit 08b475f1971b3f74c9b321941cdbe2818c25c939
Author: Scott Wegner <>
Date:   2016-04-25T16:31:13Z

    Rename DisplayDataMatchers.includes to includesDisplayData to clarify usage

commit 5a1d93ce01000df8577acd66d6e9c6ebf5d6948f
Author: Scott Wegner <>
Date:   2016-04-25T16:34:58Z

    Normalize comments to refer to 'display data' rather than 'display metadata'

commit 954e734fbde4a055ee97d84b9f1c91d598fc5de9
Author: Scott Wegner <>
Date:   2016-04-25T16:41:07Z

    Add super.populateDisplayData() to standard implementations. The current super implementation
is a no-op, but this is the recommended way to implement the pattern


> Implement the API for Static Display Metadata
> ---------------------------------------------
>                 Key: BEAM-117
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Scott Wegner
> As described in the following doc, we would like the SDK to allow associating display
metadata with PTransforms.

This message was sent by Atlassian JIRA

View raw message