beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lc...@apache.org
Subject [1/3] incubator-beam git commit: Thomas' comments
Date Wed, 20 Apr 2016 23:23:52 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master 3e0eaf53e -> 4f8cb0344


Thomas' comments


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/4d8ef733
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/4d8ef733
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/4d8ef733

Branch: refs/heads/master
Commit: 4d8ef73316171687c847c8b3b4aee0d6024ad852
Parents: 6334f72
Author: Mark Shields <markshields@google.com>
Authored: Wed Apr 20 15:59:31 2016 -0700
Committer: Luke Cwik <lcwik@google.com>
Committed: Wed Apr 20 16:06:35 2016 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/beam/sdk/util/UserCodeException.java  | 2 +-
 .../test/java/org/apache/beam/sdk/util/UserCodeExceptionTest.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/4d8ef733/sdks/java/core/src/main/java/org/apache/beam/sdk/util/UserCodeException.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/UserCodeException.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/UserCodeException.java
index ba06961..ad1cd8b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/UserCodeException.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/UserCodeException.java
@@ -68,7 +68,7 @@ public class UserCodeException extends RuntimeException {
     int currentStackSize = currentStack.length;
     int throwableStackSize = throwableStack.length;
 
-    if (throwableStack.length == 0) {
+    if (throwableStackSize == 0) {
       // Nothing to truncate.
       return;
     }

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/4d8ef733/sdks/java/core/src/test/java/org/apache/beam/sdk/util/UserCodeExceptionTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/UserCodeExceptionTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/UserCodeExceptionTest.java
index 2c66d5b..3be1146 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/UserCodeExceptionTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/UserCodeExceptionTest.java
@@ -100,7 +100,7 @@ public class UserCodeExceptionTest {
   public void robustAgainstEmptyStackTrace() {
     RuntimeException runtimeException = new RuntimeException("empty stack");
     runtimeException.setStackTrace(new StackTraceElement[0]);
-    RuntimeException wrapped = UserCodeException.wrapIf(true, runtimeException);
+    RuntimeException wrapped = UserCodeException.wrap(runtimeException);
     assertEquals(runtimeException, wrapped.getCause());
   }
 


Mime
View raw message