Return-Path: 
 <commits-return-327-apmail-beam-commits-archive=beam.apache.org@beam.incubator.apache.org>
X-Original-To: apmail-beam-commits-archive@minotaur.apache.org
Delivered-To: apmail-beam-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4039319A44
	for <apmail-beam-commits-archive@minotaur.apache.org>;
 Wed,  2 Mar 2016 01:01:25 +0000 (UTC)
Received: (qmail 61226 invoked by uid 500); 2 Mar 2016 01:01:25 -0000
Delivered-To: apmail-beam-commits-archive@beam.apache.org
Received: (qmail 61181 invoked by uid 500); 2 Mar 2016 01:01:25 -0000
Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@beam.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@beam.incubator.apache.org>
List-Post: <mailto:commits@beam.incubator.apache.org>
List-Id: <commits.beam.incubator.apache.org>
Reply-To: dev@beam.incubator.apache.org
Delivered-To: mailing list commits@beam.incubator.apache.org
Received: (qmail 61172 invoked by uid 99); 2 Mar 2016 01:01:25 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
 spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 01:01:25 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org)
 with ESMTP id C2A1D18055A
	for <commits@beam.apache.org>; Wed,  2 Mar 2016 01:01:24 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.349
X-Spam-Level: 
X-Spam-Status: No, score=-4.349 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.329] autolearn=disabled
Received: from mx2-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new,
 port 10024)
	with ESMTP id 0lpxWA3Pa3Pb for <commits@beam.apache.org>;
	Wed,  2 Mar 2016 01:01:24 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP
 id 67CA05FADB
	for <commits@beam.incubator.apache.org>;
 Wed,  2 Mar 2016 01:01:23 +0000 (UTC)
Received: (qmail 60632 invoked by uid 99); 2 Mar 2016 01:01:22 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 01:01:22 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 797A02C1F62
	for <commits@beam.incubator.apache.org>;
 Wed,  2 Mar 2016 01:01:22 +0000 (UTC)
Date: Wed, 2 Mar 2016 01:01:22 +0000 (UTC)
From: "Daniel Halperin (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12945999.1456880416000.189068.1456880482494@Atlassian.JIRA>
In-Reply-To: <JIRA.12945999.1456880416000@Atlassian.JIRA>
References: <JIRA.12945999.1456880416000@Atlassian.JIRA>
 <JIRA.12945999.1456880416211@arcas>
Subject: [jira] [Created] (BEAM-85) DataflowAssert (BeamAssert ;) needs
 sanity check that it's used correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Daniel Halperin created BEAM-85:
-----------------------------------

             Summary: DataflowAssert (BeamAssert ;) needs sanity check that it's used correctly
                 Key: BEAM-85
                 URL: https://issues.apache.org/jira/browse/BEAM-85
             Project: Beam
          Issue Type: New Feature
          Components: sdk-java-core
            Reporter: Daniel Halperin
            Assignee: Davor Bonaci


It is important that assert is applied to pipeline before the pipeline is run, otherwise it does not actually execute the test.

This code should throw an assertion error or fail in some other way.

```java
{
Pipeline p = TestPipeline.create();
PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
p.run();

DataflowAssert.thatSingleton(value).isEqualTo(true);
}
```

but it would pass silently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)