Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0AF5419C89 for ; Wed, 16 Mar 2016 17:49:37 +0000 (UTC) Received: (qmail 3087 invoked by uid 500); 16 Mar 2016 17:49:36 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 3042 invoked by uid 500); 16 Mar 2016 17:49:36 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 3033 invoked by uid 99); 16 Mar 2016 17:49:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2016 17:49:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3F691C2E58 for ; Wed, 16 Mar 2016 17:49:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id friKvLanRbYn for ; Wed, 16 Mar 2016 17:49:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id C87DE5FB2C for ; Wed, 16 Mar 2016 17:49:34 +0000 (UTC) Received: (qmail 2505 invoked by uid 99); 16 Mar 2016 17:49:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2016 17:49:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8BAFA2C1F58 for ; Wed, 16 Mar 2016 17:49:33 +0000 (UTC) Date: Wed, 16 Mar 2016 17:49:33 +0000 (UTC) From: "Ben Chambers (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (BEAM-36) TimestampedValueInMultipleWindows should use a more compact set representation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Chambers closed BEAM-36. ---------------------------- Resolution: Won't Fix As per discussion on https://github.com/apache/incubator-beam/pull/43: "We looked some more at the original Jira issue and realized that it is likely a non-issue. It was created to track the fact we needed to examine our usage of a HashSet there, since we ran into problems with the over-allocation of a hash set (eg., 64 slots to hold 23 items, etc.). When we have 1000 of these in memory at a time, the over-allocation starts to hurt. Upon further scrutiny, those WindowedValues should only be getting turned into a Set when we need to do equals or hashCode, to make sure we get an order-independent comparison. Assuming this is limited to tests, we can probably resolve the Jira issue as won't fix." > TimestampedValueInMultipleWindows should use a more compact set representation > ------------------------------------------------------------------------------ > > Key: BEAM-36 > URL: https://issues.apache.org/jira/browse/BEAM-36 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Kenneth Knowles > Priority: Trivial > Labels: Windowing > > Today TimestampedValueInMultipleWindows converts its collection of windows to a LinkedHashSet for comparisons and hashing. Since it is an immutable set, more compact representations are available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)