beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Optimize the Count CombineFn
Date Tue, 29 Mar 2016 19:40:40 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/incubator-beam/pull/88

    Optimize the Count CombineFn

    Previously the accumulator was stored as a Long.  This uses
    a singleton long[] to avoid the boxing and unboxing on every
    increment.
    
    This required changing the Coder (the format actually remains
    the same, but we have no way of declaring that) so is not
    backwards compatible with reload.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam count

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #88
    
----
commit f2bb6e86bfd71f5cda4f574c6bedfaeff172291a
Author: Robert Bradshaw <robertwb@google.com>
Date:   2016-03-29T19:28:13Z

    Optimize the Count CombineFn
    
    Previously the accumulator was stored as a Long.  This uses
    a singleton long[] to avoid the boxing and unboxing on every
    increment.
    
    This required changing the Coder (the format actually remains
    the same, but we have no way of declaring that) so is not
    backwards compatible with reload.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message