beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjchambers <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Improve the reliability of `mvn verif...
Date Thu, 17 Mar 2016 20:14:37 GMT
GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/57

    Improve the reliability of `mvn verify`

    These commits make the following changes to improve reliability of `mvn verify` and interaction
with IDEs:
    
    1. Add some casts that were causing complaints.
    2. Use separate modules for Java 8 tests (subverted from @kennknowles) and examples (following
same pattern).
    3. Stop adding the JAR to the surefire tests, since we have the classes anyways.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam fix-build

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit e8b71008c18439d4e30edf7e29bdaa58fa6e65f3
Author: Kenneth Knowles <klk@google.com>
Date:   2016-03-01T06:40:01Z

    Move Java 8 tests to their own module
    
    This allows easy setting of the compiler source and target version to
    1.8 without any fragile plugin configuration. It also allows the
    import into Eclipse to easily set separate compliance levels, as this
    is done per-Eclipse-project.

commit f06e2a977b8e8bee456d3323ab664da3b97f0aa5
Author: bchambers <bchambers@google.com>
Date:   2016-03-16T19:44:20Z

    Add casts to fix mvn verify errors

commit e5c7cf88078cbb9c2236b38d854128abb0c18c41
Author: bchambers <bchambers@google.com>
Date:   2016-03-16T21:05:41Z

    Move Java 8 examples to their own module
    
    This allows easy setting of the compiler source and target version to
    1.8 without any fragile plugin configuration. It also allows the
    import into Eclipse to easily set separate compliance levels, as this
    is done per-Eclipse-project.
    
    This parallels the approach taken with tests to support java 8.
    
    Also fixed some Checkstyle and unused variable warnings in the examples.
    These were previously hidden since the code wasn't in a directory like
    `src/{main,test}/java`. The warnings got fixed while I had the files
    open.

commit e607237b9a8f1f3d8890a5ae2193a8af1f7e7da5
Author: bchambers <bchambers@google.com>
Date:   2016-03-17T17:31:01Z

    Remove the JARs from the test additionalClasspath
    
    The class files are already available in the tests.
    
    This required moving the Avro plugin to the regular generate-sources
    phase. Running it during generate-test-sources was removing the META-INF
    from the target/classes directory, which caused test failures due to
    removing the generated auto-services definitions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message