beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjchambers <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Repeatedly#onFire should clear all fi...
Date Thu, 31 Mar 2016 22:53:08 GMT
GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/110

    Repeatedly#onFire should clear all finished bits

    Previously, Repeatedly#onFire only cleared the finished bits associated
    with the root of the sub-tree, as demonstrated by the new unit tests.
    
    This led to problems with AfterFirst#shouldFire, which checked to see if
    any of the sub-triggers have their finished bits set.
    
    Now, Repeatedly#onFire calls #resetTree, which clears all the finished
    bits in the entire sub-tree.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable 
           Travis-CI for on your fork and ensure the whole test matrix passes).
     - [ ] Replace "<Jira issue #>" in the title with the actual Jira issue 
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
          

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam repeatedly-after-first

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----
commit 2ad027f49adbcb80ffac87c3fffa81fd68c89e86
Author: Kenneth Knowles <klk@google.com>
Date:   2016-03-31T22:03:59Z

    Repeatedly#onFire should clear all finished bits
    
    Previously, Repeatedly#onFire only cleared the finished bits associated
    with the root of the sub-tree, as demonstrated by the new unit tests.
    
    This led to problems with AfterFirst#shouldFire, which checked to see if
    any of the sub-triggers have their finished bits set.
    
    Now, Repeatedly#onFire calls #resetTree, which clears all the finished
    bits in the entire sub-tree.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message