beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-116) Change runners artifactId to runners-parent
Date Fri, 18 Mar 2016 11:06:33 GMT

    [ https://issues.apache.org/jira/browse/BEAM-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201319#comment-15201319
] 

ASF GitHub Bot commented on BEAM-116:
-------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/incubator-beam/pull/59

    [BEAM-116] change runners artifactId to runners-parent

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/incubator-beam BEAM-116

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
    
----
commit 447c8af23b3fa727bba5aa97093699745d6e6f5b
Author: Maximilian Michels <mxm@apache.org>
Date:   2016-03-16T11:03:07Z

    [BEAM-116] change runners artifactId to runners-parent

----


> Change runners artifactId to runners-parent
> -------------------------------------------
>
>                 Key: BEAM-116
>                 URL: https://issues.apache.org/jira/browse/BEAM-116
>             Project: Beam
>          Issue Type: Improvement
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>
> I've seen regular cases where users use a root ArtifactId, e.g. {{runners}}, presumably
because they think it contains all the runners' code. In fact, it just contains no code. 
> I'd propose to rename the runners ArtifactId to {{runners-parent}} which makes it explicit
that it is the parent of the sub modules. This is also along the lines of the sdk, i.e. {{google-cloud-dataflow-java-sdk-parent}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message