beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-116) Change runners artifactId to runners-parent
Date Wed, 16 Mar 2016 17:56:33 GMT

    [ https://issues.apache.org/jira/browse/BEAM-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197806#comment-15197806
] 

Kenneth Knowles commented on BEAM-116:
--------------------------------------

+1. I reverted it to "runners" but I am convinced by what you say here. Do you perhaps know
a way to share maven configuration other than parent relationships, so there is no artifact
implied?

> Change runners artifactId to runners-parent
> -------------------------------------------
>
>                 Key: BEAM-116
>                 URL: https://issues.apache.org/jira/browse/BEAM-116
>             Project: Beam
>          Issue Type: Improvement
>            Reporter: Maximilian Michels
>            Priority: Minor
>
> I've seen regular cases where users use a root ArtifactId, e.g. {{runners}}, presumably
because they think it contains all the runners' code. In fact, it just contains no code. 
> I'd propose to rename the runners ArtifactId to {{runners-parent}} which makes it explicit
that it is the parent of the sub modules. This is also along the lines of the sdk, i.e. {{google-cloud-dataflow-java-sdk-parent}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message