beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-97) Input watermarks can never be null
Date Fri, 25 Mar 2016 20:49:25 GMT


ASF GitHub Bot commented on BEAM-97:

Github user asfgit closed the pull request at:

> Input watermarks can never be null
> ----------------------------------
>                 Key: BEAM-97
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
> A null input watermark (eg the result of TimerInternals.currentInputWatermarkTime())
is currently interpreted to mean 'computation is still starting and watermark is not yet known'.
However, the Google runner was also returning null for 'computation has just restarted and
previous watermark has not been established'. As a result code such as WatermarkHold would
create data holds using the first interpretation which is unsound for the second interpretation.
> Instead, input watermarks should never be null so the interpretation is never ambiguous.
The Google runner is ready to support this.

This message was sent by Atlassian JIRA

View raw message