beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Chambers (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (BEAM-36) TimestampedValueInMultipleWindows should use a more compact set representation
Date Wed, 16 Mar 2016 17:49:33 GMT

     [ https://issues.apache.org/jira/browse/BEAM-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ben Chambers closed BEAM-36.
----------------------------
    Resolution: Won't Fix

As per discussion on https://github.com/apache/incubator-beam/pull/43:

"We looked some more at the original Jira issue and realized that it is likely a non-issue.
It was created to track the fact we needed to examine our usage of a HashSet there, since
we ran into problems with the over-allocation of a hash set (eg., 64 slots to hold 23 items,
etc.). When we have 1000 of these in memory at a time, the over-allocation starts to hurt.

Upon further scrutiny, those WindowedValues should only be getting turned into a Set when
we need to do equals or hashCode, to make sure we get an order-independent comparison. Assuming
this is limited to tests, we can probably resolve the Jira issue as won't fix."

> TimestampedValueInMultipleWindows should use a more compact set representation
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-36
>                 URL: https://issues.apache.org/jira/browse/BEAM-36
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Trivial
>              Labels: Windowing
>
> Today TimestampedValueInMultipleWindows converts its collection of windows to a LinkedHashSet
for comparisons and hashing. Since it is an immutable set, more compact representations are
available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message