beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [1/2] incubator-beam git commit: Manually fix some broken uses of DataflowAssert
Date Thu, 31 Mar 2016 04:19:54 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master 9793fa2c8 -> 0c47cad48


Manually fix some broken uses of DataflowAssert

Pipeline was not run


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/a98858ad
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/a98858ad
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/a98858ad

Branch: refs/heads/master
Commit: a98858adc6ed114cc5a35becb856f1e31a0b7b49
Parents: 9793fa2
Author: Dan Halperin <dhalperi@google.com>
Authored: Tue Mar 29 23:05:49 2016 -0700
Committer: Dan Halperin <dhalperi@google.com>
Committed: Wed Mar 30 16:39:46 2016 -0700

----------------------------------------------------------------------
 .../dataflow/sdk/runners/inprocess/InProcessCreateTest.java    | 4 ++++
 .../dataflow/sdk/transforms/ApproximateQuantilesTest.java      | 6 ++----
 2 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/a98858ad/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/runners/inprocess/InProcessCreateTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/runners/inprocess/InProcessCreateTest.java
b/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/runners/inprocess/InProcessCreateTest.java
index c2010b6..227c388 100644
--- a/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/runners/inprocess/InProcessCreateTest.java
+++ b/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/runners/inprocess/InProcessCreateTest.java
@@ -73,6 +73,8 @@ public class InProcessCreateTest {
     InProcessCreate<Integer> converted = InProcessCreate.from(og);
 
     DataflowAssert.that(p.apply(converted)).containsInAnyOrder(2, 1, 3);
+
+    p.run();
   }
 
   @Test
@@ -86,6 +88,8 @@ public class InProcessCreateTest {
 
     DataflowAssert.that(p.apply(converted))
         .containsInAnyOrder(null, "foo", null, "spam", "ham", "eggs");
+
+    p.run();
   }
 
   static class Record implements Serializable {}

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/a98858ad/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/transforms/ApproximateQuantilesTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/transforms/ApproximateQuantilesTest.java
b/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/transforms/ApproximateQuantilesTest.java
index 542c2e0..1f22757 100644
--- a/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/transforms/ApproximateQuantilesTest.java
+++ b/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/transforms/ApproximateQuantilesTest.java
@@ -74,10 +74,9 @@ public class ApproximateQuantilesTest {
     PCollection<List<Integer>> quantiles =
         input.apply(ApproximateQuantiles.<Integer>globally(5));
 
-    p.run();
-
     DataflowAssert.that(quantiles)
         .containsInAnyOrder(Arrays.asList(0, 25, 50, 75, 100));
+    p.run();
   }
 
   @Test
@@ -89,10 +88,9 @@ public class ApproximateQuantilesTest {
         input.apply(
             ApproximateQuantiles.globally(5, new DescendingIntComparator()));
 
-    p.run();
-
     DataflowAssert.that(quantiles)
         .containsInAnyOrder(Arrays.asList(100, 75, 50, 25, 0));
+    p.run();
   }
 
   @Test


Mime
View raw message