batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott Kurz <sku...@gmail.com>
Subject Re: [jira] [Commented] (BATCHEE-73) stochastic tck test-failure in JobOperatorTests.testJobOperatorAbandonJobDuringARestart
Date Tue, 24 Nov 2015 18:32:44 GMT
Haven't been able to catch up to this thread.

Since I'm not sure if I will in the next couple days, a quick brain dump:

My recollection is that for JobExecution, we didn't give this enough
thought originally in the RI.  The 1.0 release allowed you to poll on a
JobExecution since it had a direct reference to the status in memory, which
we probably just started doing as a pattern without enough thought.

After realizing that the persistence service might not want to implement it
like this, and of course given that polling on the execution id is still
possible, I wish we'd have returned and "immutable" JobExecution instead,
to not encourage polling on a single JobExecution instance.

So that makes sense if you think it's OK for BatchEE users to absorb the
change.

But from a spec perspective I've kind of been stuck since any change breaks
someone potentially, and there it stands.

As far as JobContext, that should be an in-memory thing, since
getTransientUserData should return the same instance (it's not Serializable
so it would have to be the same object identity).

Will keep following as I can..



On Tue, Nov 24, 2015 at 1:09 PM, Romain Manni-Bucau (JIRA) <jira@apache.org>
wrote:

>
>     [
> https://issues.apache.org/jira/browse/BATCHEE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025005#comment-15025005
> ]
>
> Romain Manni-Bucau commented on BATCHEE-73:
> -------------------------------------------
>
> Patch can be applied, but it doesnt solve the actual issue so I would keep
> this issue open to solve it for release "N+1".
>
> > stochastic tck test-failure in
> JobOperatorTests.testJobOperatorAbandonJobDuringARestart
> >
> ---------------------------------------------------------------------------------------
> >
> >                 Key: BATCHEE-73
> >                 URL: https://issues.apache.org/jira/browse/BATCHEE-73
> >             Project: BatchEE
> >          Issue Type: Bug
> >          Components: jbatch-core
> >    Affects Versions: 0.3-incubating
> >            Reporter: Reinhard Sandtner
> >             Fix For: 0.3-incubating
> >
> >         Attachments: BATCHEE-73.patch
> >
> >
> > {{JobOperatorTests.testJobOperatorAbandonJobDuringARestart}} fails
> stochastically
> > {noformat}
> > java.lang.AssertionError: Did not see expected
> JobExecutionIsRunningException for abandon attempt during restart
> >         at
> com.ibm.jbatch.tck.utils.AssertionUtils.assertWithMessage(AssertionUtils.java:52)
> >         at
> com.ibm.jbatch.tck.tests.jslxml.JobOperatorTests.testJobOperatorAbandonJobDuringARestart(JobOperatorTests.java:345)
> >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> >         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >         at java.lang.reflect.Method.invoke(Method.java:497)
> >         at
> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> >         at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> >         at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> >         at
> org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> >         at
> org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> >         at
> org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> >         at org.testng.TestRunner.privateRun(TestRunner.java:767)
> >         at org.testng.TestRunner.run(TestRunner.java:617)
> >         at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> >         at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
> >         at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
> >         at org.testng.SuiteRunner.run(SuiteRunner.java:240)
> >         at
> org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
> >         at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
> >         at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
> >         at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
> >         at org.testng.TestNG.run(TestNG.java:1057)
> >         at
> org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:282)
> >         at
> org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:83)
> >         at
> org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:114)
> >         at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:286)
> >         at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:240)
> >         at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
> > {noformat}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message