batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BATCHEE-65) remove unnecessary try/catch in CDIBatchArtifactFactory
Date Sat, 23 May 2015 08:39:17 GMT

    [ https://issues.apache.org/jira/browse/BATCHEE-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557220#comment-14557220
] 

Romain Manni-Bucau commented on BATCHEE-65:
-------------------------------------------

few comments:

1- BatchCDIInjectionExtension: cdi 11 test shouldnt be static but by extension instance IMO
2- for your issue: can be the LocationHolderImpl which impacts children (and implicitely veto
the beans in CDI 1.1), do you want to debug (OWB 1.6 BeansDeployer#deploySingleAT)? I can
help next week if needed

> remove unnecessary try/catch in CDIBatchArtifactFactory
> -------------------------------------------------------
>
>                 Key: BATCHEE-65
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-65
>             Project: BatchEE
>          Issue Type: Improvement
>          Components: jbatch-core
>    Affects Versions: 0.3-incubating
>            Reporter: Reinhard Sandtner
>            Priority: Minor
>             Fix For: 0.3-incubating
>
>         Attachments: BATCHEE-65.patch
>
>
> resolving a CDI-Bean is in a try/catch block which catches an Exception and does nothing.
this hides useful information if an Exception has been thrown.
> you get a NPE if ie the reader could not be resolved but not the real exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message