Mailing-List: contact dev-help@batchee.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@batchee.incubator.apache.org
Date: Tue, 9 Dec 2014 10:58:12 +0000 (UTC)
From: "Romain Manni-Bucau (JIRA)" <jira@apache.org>
To: dev@batchee.incubator.apache.org
Message-ID: <JIRA.12760385.1418114059000.108524.1418122692965@Atlassian.JIRA>
In-Reply-To: <JIRA.12760385.1418114059000@Atlassian.JIRA>
References: <JIRA.12760385.1418114059000@Atlassian.JIRA>
 <JIRA.12760385.1418114059356@arcas>
Subject: [jira] [Commented] (BATCHEE-56) ChunkListener.onError() should not
 be called in case of exceptions outside of chunks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/BATCHEE-56?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1423=
9266#comment-14239266 ]=20

Romain Manni-Bucau commented on BATCHEE-56:
-------------------------------------------

Hi

Ok, rebuilding and redeploying to check we still pass the TCKs with this ch=
ange.

In batchee build we rely on openejb for testing(jdbc, jpa,...) and for tcks=
. BatchEE is well integrated to TomEE on develop branch (TomEE "trunk") but=
 it is commonly used as a simple library in any container (tomcat + openweb=
beans, tomee 1.x...)

> ChunkListener.onError() should not be called in case of exceptions outsid=
e of chunks
> -------------------------------------------------------------------------=
-----------
>
>                 Key: BATCHEE-56
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-56
>             Project: BatchEE
>          Issue Type: Bug
>          Components: jbatch-core
>    Affects Versions: 0.1-incubating, 0.2-incubating
>            Reporter: Mario K=C3=B6dding
>            Priority: Minor
>             Fix For: 0.3-incubating
>
>
> As we have some integration-tests running on different application-server=
s, we discovered some differences in the behavior of the jbatch-implementat=
ions concerning listeners in case of exceptions:
> If an exception occurs inside the ItemReader/ItemWriter open() or close()=
 methods, then in case of JBeret, the ChunkListener.onError() method is not=
 called, while the JBatch RI included in GlassFish 4 as well as Apache Batc=
hEE do call the method.
> This issue has already been discussed in the JBeret issue-tracker:
> https://github.com/jberet/jsr352/issues/25
> Cheng Fang summarizes it as follows:=20
> "A chunk-type step consists of multiple chunks, and ChunkListener is for =
these smaller chunks, not for the entire step. When ItemReader.open() is ca=
lled at the beginning of the step, we haven't come to any chunk yet, why sh=
ould the ChunkListener be called?"
> I agree with him, that according to the spec, the ChunkListener should no=
t be called in case of exceptions inside the open() and close() methods. So=
 I think the BatchEE implementation should be adjusted here. Please refer t=
o the JBeret issue linked above for more details.
> Related to this issue, I have opened a discussion on the jbatch public ma=
iling list for enhancing the error-handling with listeners:
> https://java.net/projects/jbatch/lists/public/archive/2014-12/message/3


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)