Return-Path: X-Original-To: apmail-batchee-dev-archive@minotaur.apache.org Delivered-To: apmail-batchee-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B38A211AD7 for ; Tue, 6 May 2014 08:32:40 +0000 (UTC) Received: (qmail 12693 invoked by uid 500); 6 May 2014 08:32:39 -0000 Delivered-To: apmail-batchee-dev-archive@batchee.apache.org Received: (qmail 12665 invoked by uid 500); 6 May 2014 08:32:39 -0000 Mailing-List: contact dev-help@batchee.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@batchee.incubator.apache.org Delivered-To: mailing list dev@batchee.incubator.apache.org Received: (qmail 12655 invoked by uid 99); 6 May 2014 08:32:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 08:32:38 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 06 May 2014 08:32:37 +0000 Received: (qmail 12339 invoked by uid 99); 6 May 2014 08:32:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 08:32:15 +0000 Date: Tue, 6 May 2014 08:32:15 +0000 (UTC) From: "Romain Manni-Bucau (JIRA)" To: dev@batchee.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BATCHEE-36) Befor- and AfterJob(Step)ScopeListener MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BATCHEE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990422#comment-13990422 ] Romain Manni-Bucau commented on BATCHEE-36: ------------------------------------------- well, to be honest I think we can keep it as it is today and add a CDI extension checking if JobScoped/StepScoped are used. Then when we start the batch we can just add the listeners automatically if needed without any config. When I wrote this part the main issue was the config. I added something simple but it is clear having to configure it manually is not the final solution. > Befor- and AfterJob(Step)ScopeListener > -------------------------------------- > > Key: BATCHEE-36 > URL: https://issues.apache.org/jira/browse/BATCHEE-36 > Project: BatchEE > Issue Type: Improvement > Components: batchee-extensions > Affects Versions: 0.2-incubating > Reporter: Reinhard Sandtner > Priority: Minor > > why do we provide an AfterJob(Step)ScopeListener and a BeforeJob(Step)ScopeListener? > Isn't it enough to have only one JobScopeListener and StepScopeListener which implements both methods? > {code} > public void before(){...} > public void after(){...} > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)