batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BATCHEE-36) Befor- and AfterJob(Step)ScopeListener
Date Tue, 06 May 2014 08:20:15 GMT

    [ https://issues.apache.org/jira/browse/BATCHEE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990415#comment-13990415
] 

Mark Struberg commented on BATCHEE-36:
--------------------------------------

Romain, it wont hurt you to have the other one as well.
 
And it is a major benefit for our users to have the config as simple as possible.
Thus I'd vote to have all of our scopes handled in the same code. One class for the before
and another class for the after step. To allow proper ordering for custom user scopes.
Btw, we handle step- and jobcontext maps in a single class (LocationHolder) anyway. It's really
a bit too complex as is today.

> Befor- and AfterJob(Step)ScopeListener
> --------------------------------------
>
>                 Key: BATCHEE-36
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-36
>             Project: BatchEE
>          Issue Type: Improvement
>          Components: batchee-extensions
>    Affects Versions: 0.2-incubating
>            Reporter: Reinhard Sandtner
>            Priority: Minor
>
> why do we provide an AfterJob(Step)ScopeListener and a BeforeJob(Step)ScopeListener?
> Isn't it enough to have only one JobScopeListener and StepScopeListener which implements
both methods?
> {code}
> public void before(){...}
> public void after(){...}
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message