Return-Path: 
 <dev-return-255-apmail-batchee-dev-archive=batchee.apache.org@batchee.incubator.apache.org>
X-Original-To: apmail-batchee-dev-archive@minotaur.apache.org
Delivered-To: apmail-batchee-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 22FAB11EF6
	for <apmail-batchee-dev-archive@minotaur.apache.org>;
 Mon, 28 Apr 2014 12:14:45 +0000 (UTC)
Received: (qmail 20037 invoked by uid 500); 28 Apr 2014 12:14:44 -0000
Delivered-To: apmail-batchee-dev-archive@batchee.apache.org
Received: (qmail 20008 invoked by uid 500); 28 Apr 2014 12:14:44 -0000
Mailing-List: contact dev-help@batchee.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@batchee.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@batchee.incubator.apache.org>
List-Post: <mailto:dev@batchee.incubator.apache.org>
List-Id: <dev.batchee.incubator.apache.org>
Reply-To: dev@batchee.incubator.apache.org
Delivered-To: mailing list dev@batchee.incubator.apache.org
Received: (qmail 20000 invoked by uid 99); 28 Apr 2014 12:14:43 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 12:14:43 +0000
X-ASF-Spam-Status: No, hits=-2000.7 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 28 Apr 2014 12:14:43 +0000
Received: (qmail 17929 invoked by uid 99); 28 Apr 2014 12:14:18 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 12:14:18 +0000
Date: Mon, 28 Apr 2014 12:14:18 +0000 (UTC)
From: "Romain Manni-Bucau (JIRA)" <jira@apache.org>
To: dev@batchee.incubator.apache.org
Message-ID: <JIRA.12710603.1398448665400.191156.1398687258693@arcas>
In-Reply-To: <JIRA.12710603.1398448665400@arcas>
References: <JIRA.12710603.1398448665400@arcas>
Subject: [jira] [Commented] (BATCHEE-33) BufferedItemReader#readAllItems()
 should return Iterable<R>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/BATCHEE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982954#comment-13982954 ] 

Romain Manni-Bucau commented on BATCHEE-33:
-------------------------------------------

PS: if we don't agree we can just propose both too. Iterable one will delegate to Iterator one.

> BufferedItemReader#readAllItems() should return Iterable<R>
> -----------------------------------------------------------
>
>                 Key: BATCHEE-33
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-33
>             Project: BatchEE
>          Issue Type: Improvement
>          Components: batchee-extensions
>    Affects Versions: 0.1-incubating
>            Reporter: Reinhard Sandtner
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 0.2-incubating
>
>         Attachments: batchee33.patch
>
>
> make 
> {code}
> public abstract Iterator<R> readAllItems();
> {code}
> return Iterable<R> would be easier to use it.
> The method should also be protected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)