Return-Path: X-Original-To: apmail-batchee-dev-archive@minotaur.apache.org Delivered-To: apmail-batchee-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47F4911E52 for ; Mon, 7 Apr 2014 07:02:44 +0000 (UTC) Received: (qmail 64230 invoked by uid 500); 7 Apr 2014 07:02:42 -0000 Delivered-To: apmail-batchee-dev-archive@batchee.apache.org Received: (qmail 64103 invoked by uid 500); 7 Apr 2014 07:02:42 -0000 Mailing-List: contact dev-help@batchee.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@batchee.incubator.apache.org Delivered-To: mailing list dev@batchee.incubator.apache.org Received: (qmail 64093 invoked by uid 99); 7 Apr 2014 07:02:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Apr 2014 07:02:41 +0000 X-ASF-Spam-Status: No, hits=-2000.3 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 07 Apr 2014 07:02:40 +0000 Received: (qmail 63849 invoked by uid 99); 7 Apr 2014 07:02:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Apr 2014 07:02:17 +0000 Date: Mon, 7 Apr 2014 07:02:17 +0000 (UTC) From: "Romain Manni-Bucau (JIRA)" To: dev@batchee.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BATCHEE-27) implementBufferedItemReeader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BATCHEE-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961669#comment-13961669 ] Romain Manni-Bucau commented on BATCHEE-27: ------------------------------------------- Open point: can't it be a component (aggregator?) we reuse in implementations instead of an abstract class? will allow to use inheritance for most important things. I'd expect to give an iterator for instance to the Aggregator. > implementBufferedItemReeader > ---------------------------- > > Key: BATCHEE-27 > URL: https://issues.apache.org/jira/browse/BATCHEE-27 > Project: BatchEE > Issue Type: New Feature > Components: batchee-extensions > Affects Versions: 0.1-incubating > Reporter: Mark Struberg > Assignee: Mark Struberg > Fix For: 0.2-incubating > > > Most ItemReader look the same. They first query most of the items, cache them and then return one by one from this cache. > We don't have to implement this over and over again. Instead we can provide an abstract class which does the buffer handling for us. -- This message was sent by Atlassian JIRA (v6.2#6252)