Return-Path: X-Original-To: apmail-batchee-dev-archive@minotaur.apache.org Delivered-To: apmail-batchee-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E907610C12 for ; Wed, 9 Apr 2014 05:23:46 +0000 (UTC) Received: (qmail 12116 invoked by uid 500); 9 Apr 2014 05:23:46 -0000 Delivered-To: apmail-batchee-dev-archive@batchee.apache.org Received: (qmail 12083 invoked by uid 500); 9 Apr 2014 05:23:44 -0000 Mailing-List: contact dev-help@batchee.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@batchee.incubator.apache.org Delivered-To: mailing list dev@batchee.incubator.apache.org Received: (qmail 12075 invoked by uid 99); 9 Apr 2014 05:23:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 05:23:44 +0000 X-ASF-Spam-Status: No, hits=-2000.3 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 09 Apr 2014 05:23:43 +0000 Received: (qmail 11006 invoked by uid 99); 9 Apr 2014 05:23:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 05:23:20 +0000 Date: Wed, 9 Apr 2014 05:23:20 +0000 (UTC) From: "Romain Manni-Bucau (JIRA)" To: dev@batchee.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BATCHEE-26) rename our Database table names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/BATCHEE-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963822#comment-13963822 ] Romain Manni-Bucau commented on BATCHEE-26: ------------------------------------------- Hi I think consistency is the main point. Having it db oriented is good but it needs: 1) rename fields/relationships 2) align table and column names in jpa/jdbc managers (surely share constants through an interface) The current patch is a good start but half way. What would be nice is to add a test using jdbc scripts + jdbc persistence then query with jpa and another test doing the opposite. > rename our Database table names > ------------------------------- > > Key: BATCHEE-26 > URL: https://issues.apache.org/jira/browse/BATCHEE-26 > Project: BatchEE > Issue Type: Bug > Components: jbatch-core > Affects Versions: 0.2-incubating > Reporter: Mark Struberg > Labels: newbie, patch > Fix For: 0.2-incubating > > Attachments: BATCHEE-26.patch > > > Currently our DB Tables are named 1:1 like the entities > * JobExecutionEntity > * CheckpointEntity > * JobInstanceEntity > * StepExecutionEntity > I'd rather rename them to something more meaningful: > * JB_EXECUTION > * JB_CHECKPOINT > * JB_JOBINSTANCE > * JB_STEPEXECUTION > Of course this needs a small alter table for people already using batchee-0.1. But it will be much more clear and easier to find in the db schema later. -- This message was sent by Atlassian JIRA (v6.2#6252)