batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BATCHEE-33) BufferedItemReader#readAllItems() should return Iterable<R>
Date Mon, 28 Apr 2014 13:33:17 GMT

    [ https://issues.apache.org/jira/browse/BATCHEE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983009#comment-13983009
] 

Mark Struberg commented on BATCHEE-33:
--------------------------------------

hi romain, your comments only popped up now. Feel free to reopen if you still like to change
it.

Imo createIterator does not say why and how it should behave.
readAllItems() otoh do not imply any time constraints. It just says to read all items - without
giving prejustice how long this will take and whether you read it from a stream or from a
db.

> BufferedItemReader#readAllItems() should return Iterable<R>
> -----------------------------------------------------------
>
>                 Key: BATCHEE-33
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-33
>             Project: BatchEE
>          Issue Type: Improvement
>          Components: batchee-extensions
>    Affects Versions: 0.1-incubating
>            Reporter: Reinhard Sandtner
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 0.2-incubating
>
>         Attachments: batchee33.patch
>
>
> make 
> {code}
> public abstract Iterator<R> readAllItems();
> {code}
> return Iterable<R> would be easier to use it.
> The method should also be protected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message