batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BATCHEE-33) BufferedItemReader#readAllItems() should return Iterable<R>
Date Fri, 25 Apr 2014 22:27:15 GMT

    [ https://issues.apache.org/jira/browse/BATCHEE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981435#comment-13981435
] 

Romain Manni-Bucau edited comment on BATCHEE-33 at 4/25/14 10:26 PM:
---------------------------------------------------------------------

+1 for Iterator  (see https://github.com/rmannibucau/comparator why ;))

PS: readAllItems doesn't match iterator semantic BTW, createIterator() or something else can
be better


was (Author: romain.manni-bucau):
+1 for Iterator  (see https://github.com/rmannibucau/comparator why ;))

> BufferedItemReader#readAllItems() should return Iterable<R>
> -----------------------------------------------------------
>
>                 Key: BATCHEE-33
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-33
>             Project: BatchEE
>          Issue Type: Improvement
>          Components: batchee-extensions
>    Affects Versions: 0.1-incubating
>            Reporter: Reinhard Sandtner
>            Priority: Minor
>
> make 
> {code}
> public abstract Iterator<R> readAllItems();
> {code}
> return Iterable<R> would be easier to use it.
> The method should also be protected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message