batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BATCHEE-26) rename our Database table names
Date Wed, 09 Apr 2014 05:23:20 GMT

    [ https://issues.apache.org/jira/browse/BATCHEE-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963822#comment-13963822
] 

Romain Manni-Bucau commented on BATCHEE-26:
-------------------------------------------

Hi

I think consistency is the main point. Having it db oriented is good but it needs:
1) rename fields/relationships
2) align table and column names in jpa/jdbc managers (surely share constants through an interface)

The current patch is a good start but half way.

What would be nice is to add a test using jdbc scripts + jdbc persistence then query with
jpa and another test doing the opposite.

> rename our Database table names
> -------------------------------
>
>                 Key: BATCHEE-26
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-26
>             Project: BatchEE
>          Issue Type: Bug
>          Components: jbatch-core
>    Affects Versions: 0.2-incubating
>            Reporter: Mark Struberg
>              Labels: newbie, patch
>             Fix For: 0.2-incubating
>
>         Attachments: BATCHEE-26.patch
>
>
> Currently our DB Tables are named 1:1 like the entities
> * JobExecutionEntity
> * CheckpointEntity
> * JobInstanceEntity
> * StepExecutionEntity
> I'd rather rename them to something more meaningful:
> * JB_EXECUTION
> * JB_CHECKPOINT
> * JB_JOBINSTANCE
> * JB_STEPEXECUTION
> Of course this needs a small alter table for people already using batchee-0.1. But it
will be much more clear and easier to find in the db schema later.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message