batchee-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Kurz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BATCHEE-4) Spec change on skip/retry exception matching coming in 1.1
Date Tue, 26 Nov 2013 22:09:35 GMT

    [ https://issues.apache.org/jira/browse/BATCHEE-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833139#comment-13833139
] 

Scott Kurz commented on BATCHEE-4:
----------------------------------

Sorry.. I'd meant to address that exact question.   

It would be more like:

<class name="com.ibm.jbatch.tck.tests.jslxml.ChunkTests">
  <methods> <!-- BATCHEE-4 -->
   <exclude name="testChunkRetryMultipleExceptions"/>
   <exclude name="testChunkSkipMultipleExceptions"/>
  </methods>
</class>

So you missed one, "testChunkRetryMultipleExceptions"... but we don't have to exclude the
other.   If everything goes well, we'd add a similar test back in a presumed 1.1 TCK.

I haven't gone and done the "official" TCK update zip yet, but I'm glad we had this conversation
since I couldn't get the TestNG exclude syntax to work last time I tried... now I have a working
example.

Thank you



> Spec change on skip/retry exception matching coming in 1.1
> ----------------------------------------------------------
>
>                 Key: BATCHEE-4
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-4
>             Project: BatchEE
>          Issue Type: Bug
>            Reporter: Scott Kurz
>            Priority: Minor
>
> Again, I'm just assuming this hasn't been fixed without testing based on RI knowledge.
> As discussed here:
> https://java.net/bugzilla/show_bug.cgi?id=5403
> We decided that the spec was vague with respect to a case like:
> <retryable-exception-classes>
> 	<include class="...MyParentException"/>
> 	<include class="...MyGrandchildException"/>
> 	<exclude class="....MyChildException"/>
> </retryable-exception-classes>
> where MyGrandchildException extends MyChildException which extends MyParentException
> ====
> Informally, we agreed that the future direction would be this: 
> We decided to get rid of the RI behavior, which would exclude an instance of MyGrandchildException
(under the rule that matching any 'exclude' results in exclusion).  Instead we plan to go
with a rule that says you go with the matching include/exclude closest to you in the exception
hierarchy, in which case MyGrandchildException  would be included.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message