From reviews-return-1056-archive-asf-public=cust-asf.ponee.io@bahir.apache.org  Wed Nov 28 12:20:47 2018
Return-Path: <reviews-return-1056-archive-asf-public=cust-asf.ponee.io@bahir.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id DBE87180658
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 28 Nov 2018 12:20:46 +0100 (CET)
Received: (qmail 6509 invoked by uid 500); 28 Nov 2018 11:20:46 -0000
Mailing-List: contact reviews-help@bahir.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@bahir.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@bahir.apache.org>
List-Post: <mailto:reviews@bahir.apache.org>
List-Id: <reviews.bahir.apache.org>
Reply-To: reviews@bahir.apache.org
Delivered-To: mailing list reviews@bahir.apache.org
Received: (qmail 6476 invoked by uid 99); 28 Nov 2018 11:20:45 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2018 11:20:45 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id EFEB6DFA6C; Wed, 28 Nov 2018 11:20:44 +0000 (UTC)
From: lresende <git@git.apache.org>
To: reviews@bahir.apache.org
Reply-To: reviews@bahir.apache.org
References: <git-pr-71-bahir@git.apache.org>
In-Reply-To: <git-pr-71-bahir@git.apache.org>
Subject: [GitHub] bahir pull request #71: [BAHIR-66] Switch to Java binding for ZeroMQ
Content-Type: text/plain
Message-Id: <20181128112044.EFEB6DFA6C@git1-us-west.apache.org>
Date: Wed, 28 Nov 2018 11:20:44 +0000 (UTC)

Github user lresende commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/71#discussion_r237031835
  
    --- Diff: streaming-zeromq/pom.xml ---
    @@ -45,22 +45,18 @@
           <version>${spark.version}</version>
           <scope>provided</scope>
         </dependency>
    +    <dependency>
    +      <groupId>org.zeromq</groupId>
    +      <artifactId>jeromq</artifactId>
    +      <version>0.4.3</version>
    +    </dependency>
         <dependency>
    --- End diff --
    
    Could you also please remove the previous dependencies and add the new one to the proper license files.


---