bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From emlaver <...@git.apache.org>
Subject [GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...
Date Mon, 08 Jan 2018 05:33:02 GMT
Github user emlaver commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/61#discussion_r160077409
  
    --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreRDD.scala
---
    @@ -174,7 +178,11 @@ class JsonStoreRDD(sc: SparkContext, config: CloudantConfig)
     
         implicit val postData : String = {
           if (queryUsed) {
    -        Json.stringify(Json.obj("selector" -> selector, "limit" -> 1))
    +        val jsonSelector = new JsonObject
    +        jsonSelector.addProperty("selector", selector.toString)
    +        jsonSelector.addProperty("limit", 1)
    +        jsonSelector.toString
    +        // Json.stringify(Json.obj("selector" -> selector, "limit" -> 1))
    --- End diff --
    
    Removed in 55cc844.


---

Mime
View raw message