bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From emlaver <...@git.apache.org>
Subject [GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements
Date Thu, 04 Jan 2018 14:51:16 GMT
Github user emlaver commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/60#discussion_r159669507
  
    --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreConfigManager.scala
---
    @@ -35,6 +35,7 @@ object JsonStoreConfigManager {
       private val CLOUDANT_PASSWORD_CONFIG = "cloudant.password"
       private val CLOUDANT_PROTOCOL_CONFIG = "cloudant.protocol"
       private val CLOUDANT_API_ENDPOINT = "cloudant.endpoint"
    +  private val CLOUDANT_STREAMING_BATCH_INTERVAL = "cloudant.batchInterval"
       private val STORAGE_LEVEL_FOR_CHANGES_INDEX = "cloudant.storageLevel"
    --- End diff --
    
    Yes, they should be the same.  I'll revert the documentation back to `cloudant.storageLevel`.


---

Mime
View raw message