bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ricellis <...@git.apache.org>
Subject [GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements
Date Thu, 04 Jan 2018 13:15:15 GMT
Github user ricellis commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/60#discussion_r159649060
  
    --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala
---
    @@ -72,6 +72,7 @@ class ChangesReceiver(config: CloudantChangesConfig)
             val status = headers.getOrElse("Status", IndexedSeq.empty)
             val errorMsg = "Error retrieving _changes feed " + config.getDbname + ": " +
status(0)
             reportError(errorMsg, new CloudantException(errorMsg))
    +        stop(errorMsg)
    --- End diff --
    
    Does this call to `stop` result in the errorMsg being reported twice?


---

Mime
View raw message