bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From emlaver <...@git.apache.org>
Subject [GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test
Date Mon, 18 Dec 2017 17:45:43 GMT
Github user emlaver commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/57#discussion_r157553098
  
    --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantChangesConfig.scala
---
    @@ -67,7 +67,8 @@ class CloudantChangesConfig(protocol: String, host: String, dbName:
String,
       }
     
       def getChangesReceiverUrl: String = {
    -    var url = dbUrl + "/" + defaultIndex + "?include_docs=true&feed=continuous&timeout="
+ timeout
    +    var url = dbUrl + "/" + defaultIndex + "?include_docs=true&feed=normal" +
    +      "&seq_interval=10000&timeout=" + timeout
    --- End diff --
    
    Yes, I think that's a good idea.  Fixed in f758996.


---

Mime
View raw message